Skip to content

Adjust local-state/export tests broken due to changes in 4.3 - #13379

Merged
jerelmiller merged 1 commit into
release-4.3from
jerel/fix-failing-tests
Aug 3, 2026
Merged

Adjust local-state/export tests broken due to changes in 4.3#13379
jerelmiller merged 1 commit into
release-4.3from
jerel/fix-failing-tests

Conversation

@jerelmiller

@jerelmiller jerelmiller commented Aug 3, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Fixes broken local-state/export tests added to main that changed dataState values in 4.3.

Summary by CodeRabbit

  • Tests
    • Updated streamed-response test expectations to reflect completed results and non-partial status for the initial response.

@changeset-bot

changeset-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2c2c337

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@apollo-librarian

apollo-librarian Bot commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: ac5f51998388346f63cb8301
Build Logs: View logs

✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@jerelmiller
jerelmiller enabled auto-merge (squash) August 3, 2026 16:39
@coderabbitai

coderabbitai Bot commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 989ec8a8-17ef-41c2-bd4d-9d7ce7d80b1d

📥 Commits

Reviewing files that changed from the base of the PR and between 57fff83 and 2c2c337.

📒 Files selected for processing (1)
  • src/__tests__/local-state/export.ts
📝 Walkthrough

Walkthrough

The PR updates two streamed-response test expectations. Both now use dataState: "complete" and partial: false. Loading and streaming network status assertions remain unchanged.

Changes

Streamed response test expectations

Layer / File(s) Summary
Update streamed response assertions
src/__tests__/local-state/export.ts		 Two streamed-response expectations now classify the result as complete and non-partial. Network status expectations remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: auto-cleanup

Poem

A rabbit checks the stream with care,
“Complete” now waits in every pair.
No partial crumbs remain to chase,
Network status stays in place.
Hop, hop—tests reflect the case!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the test adjustments caused by changes in version 4.3.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/__tests__/local-state/export.ts

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Aug 3, 2026

Copy link
Copy Markdown 
npm i https://pkg.pr.new/@apollo/client@13379

commit: 2c2c337

@jerelmiller
jerelmiller merged commit fefaca2 into release-4.3 Aug 3, 2026
51 checks passed
@jerelmiller
jerelmiller deleted the jerel/fix-failing-tests branch August 3, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jerelmiller